Build number fallback when product-info.json is missing #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring prepareSandbox we add some attributes to the jar manifest, one of which being "Build-SDK" - the value of the attribute is constructed from the contents of product-info.json (A metadata file located in the IDE directory). However, when the target IDE is Android Studio, this file does not exist, and the value thereby becomes null; this causes the following error: Could not determine the dependencies of task ':prepareSandbox'. > Failed to query the value of task ':prepareSandbox' property 'pluginJar'. > The value of a manifest attribute must not be null (Key=Build-SDK). This commit makes it so that we fall back on the build number (also read from the IDE directory) if product-info.json is missing.
|
Thanks once again! |
Salomon88
pushed a commit
to Salomon88/gradle-intellij-plugin
that referenced
this pull request
Feb 18, 2022
* Build number fallback when product-info.json is missing When configuring prepareSandbox we add some attributes to the jar manifest, one of which being "Build-SDK" - the value of the attribute is constructed from the contents of product-info.json (A metadata file located in the IDE directory). However, when the target IDE is Android Studio, this file does not exist, and the value thereby becomes null; this causes the following error: Could not determine the dependencies of task ':prepareSandbox'. > Failed to query the value of task ':prepareSandbox' property 'pluginJar'. > The value of a manifest attribute must not be null (Key=Build-SDK). This commit makes it so that we fall back on the build number (also read from the IDE directory) if product-info.json is missing. * CHANGES update Co-authored-by: Jakub Chrzanowski <jakub.chrzanowski@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #881
When configuring prepareSandbox we add some attributes to the jar
manifest, one of which being "Build-SDK" - when using
localPath, the value of the attributeis constructed from the contents of product-info.json (a metadata file located in the target IDE directory).
However, when the target IDE is Android Studio, this file does not exist (in recent versions at least), and the value thereby resolves to null; this causes the following error:
Could not determine the dependencies of task ':prepareSandbox'.
This commit makes it so that we fall back on the build number (also read
from the IDE directory) if product-info.json is missing.