Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitLayouts don't work correctly in some cases #273

Open
rock3r opened this issue Dec 14, 2023 · 1 comment
Open

SplitLayouts don't work correctly in some cases #273

rock3r opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
api Changes related to the public API bug Something isn't working

Comments

@rock3r
Copy link
Collaborator

rock3r commented Dec 14, 2023

As pointed out by @YasserDbeis, in some cases the SplitLayouts don't work correctly when dragging the divider. This can be caused by a bad combination of initial divider position, min, max and width. The fix is probably to change the API to not mix ratios and actual positions.

@rock3r rock3r added bug Something isn't working api Changes related to the public API labels Dec 14, 2023
@rock3r rock3r added this to the Milestone 12 — v0.12.0 milestone Dec 14, 2023
@rock3r rock3r self-assigned this Dec 14, 2023
@rock3r rock3r modified the milestones: Milestone 13, Milestone 14 Jan 14, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 8, 2024

I'm considering rewriting the split layouts based on the core logic of Accompanist's TwoPane component

@rock3r rock3r modified the milestones: Milestone 14, Milestone 15 Feb 8, 2024
@rock3r rock3r modified the milestones: Milestone 15, Milestone 16 Feb 26, 2024
@rock3r rock3r modified the milestones: Milestone 16, Milestone 17 Mar 19, 2024
@rock3r rock3r removed this from the Milestone 17 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes related to the public API bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant