Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of data classes #83

Closed
rock3r opened this issue Jul 8, 2023 · 2 comments · Fixed by #192
Closed

Remove usage of data classes #83

rock3r opened this issue Jul 8, 2023 · 2 comments · Fixed by #192
Assignees
@rock3r
Labels
api Changes related to the public API feature New feature or request
Milestone
Milestone 8 — v0.8.0

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jul 8, 2023 •
edited

They're problematic in terms of binary compat, we should use regular classes with equals and hashcode and toString implemented by hand. See this article for details.
@rock3r rock3r added the feature New feature or request label Jul 8, 2023
@rock3r rock3r added this to the Build 0.3.0 (milestone 3) milestone Jul 8, 2023
@rock3r rock3r self-assigned this Jul 8, 2023
@rock3r rock3r added the api Changes related to the public API label Jul 10, 2023
@rock3r rock3r mentioned this issue Jul 10, 2023
Closed
@rock3r
Copy link
Collaborator Author

rock3r commented Sep 1, 2023

Work is ongoing, started on 0.5.0, but will continue.

@rock3r
Copy link
Collaborator Author

rock3r commented Sep 11, 2023 •
edited

We can use something like https://github.com/drewhamilton/Poko to autogen equals/hashcode/tostring when not using data classes anymore (see pinterest/ktlint#2136 for an example)

@rock3r rock3r mentioned this issue Sep 20, 2023
Closed
This was referenced Oct 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rock3r rock3r

Labels
api Changes related to the public API feature New feature or request
Projects
None yet
Milestone
Milestone 8 — v0.8.0
Development

Successfully merging a pull request may close this issue.

The big refactor — step 1: prep work JetBrains/jewel
1 participant
@rock3r