PRJ-778 Optimize Dockerfile and its workaround #17
Conversation
# Conflicts: # Dockerfile
# Conflicts: # Dockerfile
# Conflicts: # Dockerfile
# Conflicts: # Dockerfile
# Conflicts: # Dockerfile
| function string_filter { | ||
| sed -z 's/ */ /g;s/\n//g' $1 | ||
| } |
There was a problem hiding this comment.
| function string_filter { | |
| sed -z 's/ */ /g;s/\n//g' $1 | |
| } | |
| string_filter() { | |
| sed -z 's/ */ /g;s/\n//g' $1 | |
| } |
| *datagrip*) | ||
| SOFTWARE_LIST=$(string_filter <<- EOM | ||
|
|
||
| EOM | ||
| ) | ||
| ADDITIONAL_COMMANDS=$(string_filter <<- EOM | ||
|
|
||
| EOM | ||
| );; | ||
|
|
||
| # | ||
| # Block for PhpStorm | ||
| *PhpStorm*) | ||
| SOFTWARE_LIST=$(string_filter <<- EOM | ||
|
|
||
| EOM | ||
| ) | ||
| ADDITIONAL_COMMANDS=$(string_filter <<- EOM | ||
|
|
||
| EOM | ||
| );; |
There was a problem hiding this comment.
A lot of duplication, and I have no idea how to make it more compact. If you have, please do
There was a problem hiding this comment.
I have some ideas about this. In few days I`ll try to add smth
There was a problem hiding this comment.
@Avvessalom unfortunately I cant optimize this(
For now I have only one solution without code duplcation, but it required a many (at least one for each variant of IDE) files, witch store software list for each IDE.
But I think this is not a good solution.
Maybe we can accept this solution and, in future, give more convinient way?
There was a problem hiding this comment.
Discussed here: #16 (comment). So let's leave it if we can't improve it more.
|
Could you please clarify why there are two PRs (this one and #16) with some colliding changes? Which one you want to merge? Please also squash some commits it the both PRs: for now, there are many. |
|
We're discontinuing the development of projector-docker and no longer accepting contributions, sorry. |
|
您好，俺已经收到了恁里邮件，谢谢哈~
|
Resolve PRJ-778
Optimize Dockerfile and its workaround to almost perfect base image