Attach to Unity Editor configuration from dll project

[van800]

In Unity Dll project we have run-configuration Attach to Unity Editor.
Previously it worked in one click when one Unity instance was present.
Now it just shows error pop-up.

[van800]

Same behavior for regular Unity project when EditorInstance.json is missing for some reason.

[van800]

@citizenmatt the plan is to restore attaching to single instance of opened Unity and show dialog if there is more than one. Do you agree?

[citizenmatt]

The attach to single instance step was removed because it's essentially attaching to a random instance of Unity, and IMO it's better to show a dialog to confirm it's the right project in this case, and we shouldn't normally hit this scenario because either Unity or the plugin create EditorInstance.json. The main bug here is that showing the dialog has broken, probably because we've pushed checks to a separate thread.

How about this:

• Get list of editor processes
• Find the editor that matches the last attached process id, if it exists
• Else find the editor that matches EditorInstance.json, if it exists
• Else find the editor that matches the current project name, if it exists
• Show dialog for confirmation

There are circumstances on Windows (essentially not launched from Hub, with the -projectPath parameter) where we don't know an editor instance's project name, so we'd show the dialog. But the next time they hit debug, we've saved the pid, so it should match and attach without showing the dialog.

[Borluse]

Is there any workaround currently? It's totally unusable for me because our whole scripts have been move out of Unity.

[van800]

There is still Attach to Unity in the main menu.

[Borluse]

not working, it can't find unity.

[Borluse]

also, if i've attached to unity by rider 2019.2, then 2019.3 works perfectly, but not after restart unity.

[citizenmatt]

@Borluse From the screenshot above - did you have Unity running at that time? If so, what's the name of the Unity process? We basically get the current list of processes and filter down by process name.

[Borluse]

@Borluse From the screenshot above - did you have Unity running at that time? If so, what's the name of the Unity process? We basically get the current list of processes and filter down by process name.

Yes, it is running.
and task manager

EditorInstance.json is correct

[van800]

This issue might be caused by #1454
I can reproduce it.

[Borluse]

This issue might be caused by #1454
I can reproduce it.

Exactly, i used to start my project from commandline. Tried starting unity directly, and it seems working.

[citizenmatt]

The problem is that the command line has a backslash followed by a quote, e.g. Unity.exe "C:\Projects\SpaceGame\", and the code to extract the project name is treating the \" as an escape char, so instead of removing the quotes, it removes the \ and leaves the quotes. This breaks path parsing, which causes an exception, which breaks the whole dialog.

Apologies for this, a fix is in progress as part of #1450, in the meantime, the workaround is to avoid the trailing slash in the command line, or even to use forward slashes, which is what Unity Hub does.

[Borluse]

The problem is that the command line has a backslash followed by a quote, e.g. Unity.exe "C:\Projects\SpaceGame\", and the code to extract the project name is treating the \" as an escape char, so instead of removing the quotes, it removes the \ and leaves the quotes. This breaks path parsing, which causes an exception, which breaks the whole dialog.

Apologies for this, a fix is in progress as part of #1450, in the meantime, the workaround is to avoid the trailing slash in the command line, or even to use forward slashes, which is what Unity Hub does.

Thanks! Changing commandline's project path from "d:\xx\xx" to "d:/xx/xx" works.