Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate code completion for StateMachineBehaviour event functions #879

Closed
citizenmatt opened this issue Nov 2, 2018 · 0 comments
Closed
Assignees
Milestone

Comments

@citizenmatt
Copy link
Member

Rider will suggest event functions for classes deriving from StateMachineBehaviour, but those event functions are already defined as virtual methods on the StateMachineBehaviour class, resulting in duplicate entries in code completion - once as an event function and again as an override to a virtual function.

The virtual methods have overloads that are not listed in the documentation as event functions, and when overridden are highlighted as having an incorrect method signature (see #876).

A simple fix would be to remove all event functions for StateMachineBehaviour, but then we'd lose things like the gutter highlight and summary tooltip. It might be better to add the overloads into api.xml (mark the final AnimationPlayableController parameter as optional) and add a flag to not suggest these, or to check for a virtual method of the same name when adding code completion (is this an expensive check?)

@citizenmatt citizenmatt added this to the Rider 2019.1 milestone Feb 5, 2019
@citizenmatt citizenmatt self-assigned this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant