You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that the style definition uses .sprite-symbol-usage but the class applied to the inner svg element is icon-spite as configured.
The traced the issue back to this config setup: https://github.com/JetBrains/svg-mixer/blob/master/packages/svg-mixer/lib/stack-sprite.js#L16-L22 I'm not an expert with classes but I think what is happening is that the getter's this will refer to the original object that encloses it, and not a reference to the class after merge. I have a fix but ultimately couldn't get tests working so will submit a PR and hope CI can validate it.
The text was updated successfully, but these errors were encountered:
Expected behavior
When
usageClassName
is provided, the output svg spritesheet should use it to generate the target styles.Current behavior
When
usageClassName
is provided, the output svg spritesheet does not use it but instead uses the default value.Steps to reproduce
Using the following config:
My spritesheet is emitting the following (formatted for clarity):
Note that the
style
definition uses.sprite-symbol-usage
but the class applied to the inner svg element isicon-spite
as configured.The traced the issue back to this config setup: https://github.com/JetBrains/svg-mixer/blob/master/packages/svg-mixer/lib/stack-sprite.js#L16-L22 I'm not an expert with classes but I think what is happening is that the getter's
this
will refer to the original object that encloses it, and not a reference to the class after merge. I have a fix but ultimately couldn't get tests working so will submit a PR and hope CI can validate it.The text was updated successfully, but these errors were encountered: