Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault token is shown in plaintext in build parameters after the build. #52

Open
Albibek opened this issue Feb 2, 2022 · 0 comments
Open

Comments

@Albibek
Copy link

Albibek commented Feb 2, 2022

When the build is finished or in progress, the vault wrapped token used by build to fetch secrets can be viewed in plain text. Event though the token is one-time and uses wrapping it is possible to trick the agent on not using it for this single time. After that the agent will fail with the error leaving the token usabele to fetch the secrets used by build.

Proposed solution: set type=password, display=hidden on teamcity.vault.wrapped.token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant