Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add web-types to package.json exactly? #11

Closed
m-thomson opened this issue Sep 30, 2019 · 4 comments
Closed

How to add web-types to package.json exactly? #11

m-thomson opened this issue Sep 30, 2019 · 4 comments

Comments

@m-thomson
Copy link

I might be missing something but how exactly is one supposed to add web-types to package.json?

The docs only say:

link them through web-types property in package.json

But that's not clear to me. Should the property be an array or an object? Should the value(s) point to the web-type definition folder, its package.json file, its *.web-types.json file? Where?

Please provide an example. Thanks.

@piotrtomiak
Copy link
Collaborator

@m-thomson Thanks for feedback. I've updated documentation. Let me know if something is still unclear!

@m-thomson
Copy link
Author

m-thomson commented Oct 1, 2019

Great, thanks for the quick response. Do you know if anyone is working on web-types for https://vue.ant.design ?

I'd be happy to contribute.

@piotrtomiak
Copy link
Collaborator

I've had a look at their repo https://github.com/vueComponent/ant-design-vue and it doesn't seem there is any active or closed PR with generation of web-types. I think it's best to include web-types generation into the library build process, similarly to how it's done for quasar-framework and others, so I would advise creating an issue and/or PR there.

If you wish to contribute web-types for older versions of the library as well, feel free to create PR here and I will publish files.

@piotrtomiak
Copy link
Collaborator

@m-thomson I've created an issue in vue-ant-design repository to create web-types for the package. Feel free to comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants