XD-580 Perform fsync before writing new DB root #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to perform
fsync
before writing a new database root to ensure that the database root is written only after all other transaction data were persisted to disk. Without it there is a significant risk of getting corrupted database on a system failure, because the OS is free to persist cached file pages to disk out of order.Most probably the
fsync
will cause some performance degradation, but I guess reliability is more important.