Allow macOS to use CMD+R to refresh repositories #13
Conversation
|
I like the idea but not the execution. I've also seen also Ctrl+R for Linux and, less often, for Windows. In other words, to cover all the cases it should be a single method that checks for any refresh combination (depending on the platform). Probably a function (even an extension function) that checks if it's the right combination for the right platform. However, thinking a bit more about the itself, the problem is not exclusive of the refresh, it's also present in the quick commit (ctrl+enter) and a few dialogs if my memory does not fail. So I'd like to fix all the cases where ctrl/cmd rather than apply a patch specific for this case. If you want to update the PR doing so it'd be great. Otherwise I'll change it myself at some point (probably soon). Doing a quick overview, I'd create an object class that contains a lazy property with the current OS and one method for each possible combination. |
|
Thinking about it a bit more, ignore my suggestion of how to do it. I think that creating a map of a new data class for each platform would be a better idea, since it would allow us to also directly map each combination with its corresponding feature and display these shortcuts as text tooltips. The concept is similar but the OS is checked once. Whenever a key event is fired, it should be compared with the entries from the dictionary rather than verifying each combination. It may get quite more complex than I was anticipating since it will require to change multiple components (Aside from adding the tooltips to each button). Let me know what do you think. |
|
I think the approach described in your last comment sounds good, but I'm not sure how it would look in terms of implementation. I think that it is best that you do an initial implementation which I could expand on in the future. Feel free to close the PR if you would rather do that first. |
This feature allows to easily add new keybindings (programmatically) to features accross the app. Should also fix the issue that #13 tried to solve
|
A bit late but I've implemented what I mentioned before. It needs some polishing but should work just fine. |
On macOS it is pretty common to use Command + R to refresh views as opposed to F5. This change does not remove the ability to use F5 but it adds a case for if the platform is macOS to use Command + R instead.