Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom certificates #48

Open
long76 opened this issue Nov 24, 2022 · 9 comments
Open

Support for custom certificates #48

long76 opened this issue Nov 24, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@long76
Copy link

long76 commented Nov 24, 2022

Describe the bug
SSL error by self-signed certificate.

To Reproduce
Steps to reproduce the behavior:

  1. clone project by git shell from server with self-signed cert
  2. add repo to gitnuro
  3. press pull button

Expected behavior
pull sucessfull

Screenshots
2022-11-24_09-31-44

Desktop (please complete the following information):

  • OS: Kubuntu
  • Version 20.04

maybe possible add trusted store from store - in path /etc/ssl/certs/ca-certificates.crt

@long76 long76 added the bug Something isn't working label Nov 24, 2022
@JetpackDuba
Copy link
Owner

Thanks for the report!😃

I'm busy for a few weeks but I'll give some feedback ASAP.

@JetpackDuba
Copy link
Owner

Sorry for getting back so late.

Did you use the JAR or the flatpak version?

@long76
Copy link
Author

long76 commented May 6, 2023

Sorry for getting back so late.

Did you use the JAR or the flatpak version?

Jar

@JetpackDuba
Copy link
Owner

Can you try importing the certificate using the keytool utility? As shown here https://stackoverflow.com/a/4326346/4907735

I've used this exact command in the past with Android Studio, I hope it works here too.

@long76
Copy link
Author

long76 commented May 6, 2023

Can you try importing the certificate using the keytool utility? As shown here https://stackoverflow.com/a/4326346/4907735

I've used this exact command in the past with Android Studio, I hope it works here too.

yes i know about it but maybe i can just put my certs in folder with jar and program add certs in trust store in runtime? just if i update jdk cacerts will be overrided

@long76
Copy link
Author

long76 commented May 6, 2023

best sostion on this use ca-certificates-java package but i can't use it in portable jdk

@JetpackDuba
Copy link
Owner

Oke, I'll look again into it in the future as a new feature rather than a bug. I don't know much about certificates and such stuff, but it's probably feasible.

Thanks for your feedback!

@JetpackDuba JetpackDuba changed the title SSL error Support for custom certificates May 10, 2023
@JetpackDuba JetpackDuba added enhancement New feature or request and removed bug Something isn't working labels May 10, 2023
@long76
Copy link
Author

long76 commented May 24, 2023

For more usabilty if was ssl error GitNuro may suggest user add repo url in exclude for checking certs. And was great if will be some dialog or smth else with list excluded url for check. I see similar behavour in Megit(too use Java) https://github.com/eclipsesource/megit

@JetpackDuba
Copy link
Owner

Thanks! I've added the suggestion as part of #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants