Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch subscribe list functionality contains error #64

Closed
Jhut89 opened this issue May 10, 2019 · 2 comments
Closed

Batch subscribe list functionality contains error #64

Jhut89 opened this issue May 10, 2019 · 2 comments
Assignees
@Jhut89
Labels
Bug Resolved Acceptance criteria for resolution was met.

Comments

@Jhut89
Copy link
Owner

Jhut89 commented May 10, 2019 •
edited

Describe the bug
Unable to batch subscribe a list of emails because an ID check is looking for a non-existent class member.

https://github.com/Jhut89/Mailchimp-API-3.0-PHP/blob/master/src/Resources/Lists.php#L54

This line should be a check like:
$this->throwIfNot("id", $this->list_id);

Expected behavior
Batch subscribe request should fail only when no list ID ahas been provided.

Additional context
Will fix in a new release.
@Jhut89 Jhut89 mentioned this issue May 10, 2019
Merged
@Jhut89
Copy link
Owner Author

Jhut89 commented May 10, 2019

PR: #65

@Jhut89
Copy link
Owner Author

Jhut89 commented May 10, 2019

Fixed in 3.1.1

@Jhut89 Jhut89 closed this as completed May 10, 2019
@Jhut89 Jhut89 added the Bug label May 10, 2019
@Jhut89 Jhut89 self-assigned this May 10, 2019
@Jhut89 Jhut89 added the Resolved Acceptance criteria for resolution was met. label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jhut89 Jhut89

Labels
Bug Resolved Acceptance criteria for resolution was met.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jhut89