Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onChange does not fire on empty content #106

Closed
davidkonrad opened this issue Jun 23, 2019 · 4 comments
Closed

onChange does not fire on empty content #106

davidkonrad opened this issue Jun 23, 2019 · 4 comments

Comments

@davidkonrad
Copy link
Contributor

Great work! Just discovered and started using it. By far the best vanilla JS-editor I have seen,
I noticed that onChange not fire when you empty the editor. For example by deleting all content using backspace. So the only choice is to hook into another event like onKeyUp. Not optimal for performance,
@JiHong88
Copy link
Owner

Hi @davidkonrad

Thanks for your feedback!

I fixed it.

It will be applied to the next version.

Thank you : )

@JiHong88
Copy link
Owner

Hi @davidkonrad

Fixed in v2.16.0

Thank you.

@davidkonrad
Copy link
Contributor Author

Tanks a lot! Have not tried it out yet, but guess it is fixed. Have made a PR with danish translations, da.js,. Hope I have done it all correctly.

@JiHong88
Copy link
Owner

Thank you :)

Updated to version 2.16.1

@JiHong88 JiHong88 closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidkonrad @JiHong88