Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working inside tables #91

Closed
DeZZar opened this issue May 3, 2019 · 2 comments
Closed

Working inside tables #91

DeZZar opened this issue May 3, 2019 · 2 comments

Comments

@DeZZar
Copy link

DeZZar commented May 3, 2019

Hi,

Great plugin - especially like that it is plan JS without dependencies - great work!

I just have one item to raise - and although the undo button can be used in the following situation I think it is worth considering a change to the code to cater for this. When a user has the cursor placed inside a table cell without any content and the backspace key is pressed the cell is removed from the HTML and although the border styling sometimes remains making it look as though a cell exists the user cannot place the cursor back inside the cell or restore the cell without clicking undo. If the user then starts to add rows or columns in an attempt to fix the issue it only gets worse and eventually the table has to be deleted. This doesnt occur when the cell contains text. Perhaps trap the keystroke and check if the cursor is inside an empty cell to avoid accidental removal of cells?

This is of course in the context of a user who is not familiar with HTML and cannot inspect and correct the issue themselves (a large part of the target end user audience I assume).

By way of an enhancement it would also be good to be able to fix the width of the table or columns so that dont jump around as you start to add text to them. Perhaps via an additional couple of buttons in the table pop-up menu?

@JiHong88
Copy link
Owner

JiHong88 commented May 3, 2019

Hi @DeZZar ,

Thank you for your feedback!

Fixed in v2.14.0 : )

@DeZZar DeZZar closed this as completed May 7, 2019
@DeZZar
Copy link
Author

DeZZar commented May 7, 2019

@JiHong88 - fantastic - works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants