Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Indentation on tables #93

Closed
DeZZar opened this issue May 7, 2019 · 5 comments
Closed

Feature: Indentation on tables #93

DeZZar opened this issue May 7, 2019 · 5 comments

Comments

@DeZZar
Copy link

DeZZar commented May 7, 2019

Hi @JiHong88,

Just looking at the indentation functionality and found that when you put the cursor on the left side of a table and click indent it selects and indends all other content and not the table.

This might not be an issue in your original implementation as you had tables as full width. I've modified this slightly to allow table width to be auto, max-width 100 and set the cell width to a minimum. Tables now grow appropriately based on content. However, if the user wants to indent the table to align the content it wont indent (doesnt apply margin-left to tables).

Is there any change you might be able to make an update to apply the same margin to tables with the indent tool?

  • Derrick
@JiHong88
Copy link
Owner

Hi @DeZZar

I'll upgrade a this feature soon.

Tabkey behavior is easy to implement.

If you have modified the table plugin, is there any code I can refer to?

@JiHong88
Copy link
Owner

Hi @DeZZar

When the cursor is on the left side of the table, the window's selection object will bring the entire area of the editor.

So I modified it to not update the selection object in that situation.

Now, when you use the tab key on the left side of the table, the indent will be applied to the position of the previous cursor position.

Updated in v2.15.0.

Thank you :)

@DeZZar
Copy link
Author

DeZZar commented May 21, 2019

@JiHong88 thanks again mate!

@DeZZar DeZZar closed this as completed May 21, 2019
@JiHong88
Copy link
Owner

There was a critical bug in version 2.15.0.

Fixed in v2.15.1.

Thank you.

@JiHong88
Copy link
Owner

HI @DeZZar ,

Fixed again v2.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants