Danish translations #108
Merged
Danish translations #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidkonrad :) Thanks a lot! Can you modify lang/da.js more? Words related to tables have been added. ...
minSize: 'Min size',
tableHeader: 'Table header',
mergeCells: 'Merge cells',
splitCells: 'Split Cells',
HorizontalSplit: 'Horizontal split',
VerticalSplit: 'Vertical split' |
|
Yes, I'll do that instantly. Hang on. FYI: Translations regarding tables
and hr-rules does not seem to take effect. Have not investigated further
(or checked with latest version) just a heads up
regards,
david
…On Sun, Jun 30, 2019 at 6:31 PM JiHong.Lee ***@***.***> wrote:
Hi @davidkonrad <https://github.com/davidkonrad> :)
Thanks a lot!
Can you modify lang/da.js more?
Words related to tables have been added.
...
minSize: 'Min size',
tableHeader: 'Table header',
mergeCells: 'Merge cells',
splitCells: 'Split Cells',
HorizontalSplit: 'Horizontal split',
VerticalSplit: 'Vertical split'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPAW5AISOMFSODYPSBS25LP5DNWJANCNFSM4H4M4X5A>
.
|
|
Done. The additions seem to be included in the PR, so no further action
needed (from me), I guess. Have just updated and pushed to the repo.
Sorry, but I am not skilled to do this :) The only PR I have done before
was to Bootstrap Typeahead 5 years ago :)
regards,
david
…On Sun, Jun 30, 2019 at 7:00 PM david konrad ***@***.***> wrote:
Yes, I'll do that instantly. Hang on. FYI: Translations regarding tables
and hr-rules does not seem to take effect. Have not investigated further
(or checked with latest version) just a heads up
regards,
david
On Sun, Jun 30, 2019 at 6:31 PM JiHong.Lee ***@***.***>
wrote:
> Hi @davidkonrad <https://github.com/davidkonrad> :)
>
> Thanks a lot!
>
> Can you modify lang/da.js more?
>
> Words related to tables have been added.
>
> ...
> minSize: 'Min size',
> tableHeader: 'Table header',
> mergeCells: 'Merge cells',
> splitCells: 'Split Cells',
> HorizontalSplit: 'Horizontal split',
> VerticalSplit: 'Vertical split'
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#108>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABPAW5AISOMFSODYPSBS25LP5DNWJANCNFSM4H4M4X5A>
> .
>
|
|
Ok, That's enough about that : ) Thank you so much for your translation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope I have done it all correct. There is only two file changes: A lang/da.js and a change to lang/index.js. The translations does not seem to take effect on table and links, but I think this is a naming issue that will be corrected eventually.