Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #197

Closed
tswistak opened this issue Feb 3, 2020 · 4 comments
Closed

TypeScript support #197

tswistak opened this issue Feb 3, 2020 · 4 comments
Milestone

Comments

@tswistak
Copy link
Contributor

tswistak commented Feb 3, 2020

Hi,
Thanks for the library, it's a good piece of work.
Do you have plans for providing TypeScript support for the library (at least typings)? I'm using the library in a TypeScript project and when of course it's not a problem to use plain JS libs, it would make many things easier.

Cheers!

@Datyriam
Copy link

Datyriam commented Feb 4, 2020

This is still incomplete (only has the main suneditor module and the plugins modules defined) but should help you on your way:
https://hastebin.com/odafulemet.cs

@tswistak
Copy link
Contributor Author

tswistak commented Feb 4, 2020

Thanks! However, I prefer to wait for types to be on a package manager to not worry about updating them manually (it can be easily forgotten to download new or to change to NPM ones when they are ready).

@JiHong88
Copy link
Owner

JiHong88 commented Mar 13, 2020

Thank you
I'll notify you know when version is update.
And there is a question.
index.d.ts#L76
codeMirrorEditor is the object returned after executing options.codeMirror.src.fromTextArea().
Is this code needed?

@JiHong88
Copy link
Owner

The 2.27.0 version has been updated.
If there is an issue, please register as a new issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants