Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan for TypeScript supporting? #89

Closed
yswtrue opened this issue Feb 5, 2021 · 6 comments · Fixed by #185
Closed

Is there any plan for TypeScript supporting? #89

yswtrue opened this issue Feb 5, 2021 · 6 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request P2 Normal issue

Comments

@yswtrue
Copy link

yswtrue commented Feb 5, 2021

Is there any plan for TypeScript supporting?

@JiLiZART
Copy link
Owner

JiLiZART commented Feb 5, 2021

Yep in plans, type files.

@GetPastTheMonkey
Copy link

Is this still planned? If so, do you have a time estimate?

@JiLiZART
Copy link
Owner

I already started to convert my tests to typescript and write some definition files

@JiLiZART JiLiZART added the P2 Normal issue label Sep 28, 2023
@mmichaelis
Copy link

Just in case it is interesting, here are our typings we have tried to introduce for BBob (Permlink of current state, often refactored currently when we go deeper down the API): https://github.com/CoreMedia/ckeditor-plugins/tree/bcfca6fe1ed42aa3d9d15ed4b3ae67c0620ed81e/packages/ckeditor5-bbcode/types/%40bbob

Also got inspired by the PoC-branch that already exists.

I must admit, they contain many rough guesses (often shortened by just using unknown as type) as from outside the API is complex (and powerful regarding its possible extension points). Nevertheless, as the API is that rich, it would for sure benefit from proper typings.

@Hanhula
Copy link

Hanhula commented Oct 26, 2023

Excited to see this looking like it's coming closer to fruition with the in-progress CR! Thanks for working on it!

@JiLiZART JiLiZART linked a pull request Mar 27, 2024 that will close this issue
@JiLiZART
Copy link
Owner

Typescript support deployed in 4.0.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Normal issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants