Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(lexer): make lexer faster #50

Merged
merged 33 commits into from Dec 8, 2020
Merged

WIP: feat(lexer): make lexer faster #50

merged 33 commits into from Dec 8, 2020

Conversation

JiLiZART
Copy link
Owner

@JiLiZART JiLiZART commented Sep 24, 2019

Trying to rewrite lexer for better understandability and make it faster than old one.

Also potentially fixes #36

@JiLiZART JiLiZART changed the title feat(lexer): make lexer faster WIP: feat(lexer): make lexer faster Jan 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #50 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage      94%   93.93%   -0.08%     
==========================================
  Files          15       15              
  Lines         484      478       -6     
  Branches      105      109       +4     
==========================================
- Hits          455      449       -6     
  Misses         23       23              
  Partials        6        6
Impacted Files Coverage Δ
packages/bbob-parser/src/lexer.js 100% <100%> (ø) ⬆️
packages/bbob-parser/src/utils.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc7f66...a8f2d85. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   93.00%   93.93%   +0.92%     
==========================================
  Files          15       15              
  Lines         529      478      -51     
  Branches      120      109      -11     
==========================================
- Hits          492      449      -43     
+ Misses         30       23       -7     
+ Partials        7        6       -1     
Impacted Files Coverage Δ
packages/bbob-parser/src/lexer.js 100.00% <100.00%> (ø)
packages/bbob-plugin-helper/src/TagNode.js 61.53% <0.00%> (-17.04%) ⬇️
packages/bbob-core/src/index.js 90.47% <0.00%> (-0.44%) ⬇️
packages/bbob-plugin-helper/src/index.js 96.00% <0.00%> (-0.30%) ⬇️
packages/bbob-parser/src/utils.js 100.00% <0.00%> (ø)
packages/bbob-react/src/Component.js 100.00% <0.00%> (ø)
packages/bbob-preset-html5/src/defaultTags.js 95.65% <0.00%> (+0.30%) ⬆️
packages/bbob-parser/src/parse.js 96.20% <0.00%> (+1.94%) ⬆️
packages/bbob-parser/src/Token.js 100.00% <0.00%> (+7.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba090bf...8511f50. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #50 (3c51f27) into master (fda6ddd) will increase coverage by 0.05%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   93.48%   93.53%   +0.05%     
==========================================
  Files          15       15              
  Lines         537      588      +51     
  Branches      123      132       +9     
==========================================
+ Hits          502      550      +48     
- Misses         29       32       +3     
  Partials        6        6              
Impacted Files Coverage Δ
packages/bbob-parser/src/parse.js 94.25% <ø> (ø)
packages/bbob-parser/src/lexer.js 98.08% <97.67%> (-1.92%) ⬇️
packages/bbob-parser/src/Token.js 92.64% <100.00%> (ø)
packages/bbob-parser/src/utils.js 100.00% <100.00%> (ø)
packages/bbob-plugin-helper/src/TagNode.js 78.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda6ddd...7446156. Read the comment docs.

@JiLiZART JiLiZART merged commit 772d422 into master Dec 8, 2020
@JiLiZART JiLiZART deleted the feature/lexer-perf branch December 8, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants