Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The implement of NonLocalUNet is quiet different from the official implement #15

Closed
Lloyd-Pottiger opened this issue Mar 14, 2022 · 3 comments

Comments

@Lloyd-Pottiger
Copy link

The implement of NonLocalUNet in this repo is VGG encoder + NonLocal center + UNet decoder, but the official implement is: replacing upsample and downsample with Global Aggregation Block, reduce the layers of UNet and replace the Concatenation with Add.
Refer to https://github.com/divelab/Non-local-U-Nets、https://arxiv.org/abs/1812.04103

@JiYuanFeng
Copy link
Owner

Hi, thank you for pointing this out. In fact, in the paper, we did not compare with NonLocalUNet, instead of comparing with the method of UNet + NonLocal operation.

@Lloyd-Pottiger
Copy link
Author

You are right. Maybe you should change NonLocalUNet into UNet+NonLocal in README which may be missleading.

@JiYuanFeng
Copy link
Owner

Yes, thank you for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants