-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avert about weird behaviors with Pretrained models in the README #135
Comments
Hi@ferreram, |
Hi @Ihiceu, |
@ferreram Why the factor of 1.17? How does it come into existence? |
@WASCHMASCHINE I have no idea and did not have the time to dive into this but it was reported by other as well #64 |
@ferreram |
Hi there,
First I would like to thank you for your work and releasing your code and pre-trained models!
I have been playing with the code and ran into some troubles in the results obtained with the pre-trained models. This is due to three facts. First, "align_corners=True" should be added to the upsample functions for Pytorch version higher than 0.4. Second, with SceneFlow and the pre-trained model, the output disparities should be multiplied by 1.17. And finally, with torchvision > 0.2.0, RGB images should be loaded without adding ".astype('float32'))".
I think you should add these pieces of information in the README.md, so people don't get confuse and don't lose too much time trying to fix these issues.
Thansk again for sharing your code.
Cheers,
Maxime
The text was updated successfully, but these errors were encountered: