Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto_clip_fac in case of resuming from checkpoint #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greaber
Copy link

@greaber greaber commented Sep 10, 2017

When resuming from a checkpoint, self.iter is not zero, but self._h_max is still undefined, so the optimizer would error. The PR checks directly if self._h_max is defined, which should always work.

@JianGoForIt
Copy link
Owner

Hi @greaber

Thanks for catching the bug and submit the PR. For this error, I think the better way to resolve is to get h_max into the states saved and loaded.

Cheers,

Jian

@greaber
Copy link
Author

greaber commented Sep 12, 2017

I see. Is there any reason h_max and h_min can't just be set to 0 in __init__ and treated exactly as other parts of the state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants