Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix book-section overflow error #41

Merged
merged 2 commits into from Oct 1, 2020
Merged

Fix book-section overflow error #41

merged 2 commits into from Oct 1, 2020

Conversation

parthpanchal123
Copy link
Contributor

The Container size was hardcoded as 200 therfore it would overflow in many devices as shown below.

image

Image demonstrating the fix :

image

  • Simply removing the hardcoded size, the container would automatically adjust itself according to its children's size, thus fixing the overflow issue .

@JideGuru JideGuru merged commit 3705081 into JideGuru:master Oct 1, 2020
@mrifni
Copy link

mrifni commented Oct 1, 2020

how come this is a fix ? I cant see a code change relevennt to the described issue ?

@parthpanchal123
Copy link
Contributor Author

parthpanchal123 commented Oct 1, 2020

how come this is a fix ? I cant see a code change relevennt to the described issue ?

Previously the height of the Container was hardcoded to 200 and hence the overflow was caused . The fix was simply removing the height of the container and by doing that there is just enough space to contain the child of container .

@parthpanchal123 parthpanchal123 deleted the fix-booksection-overflow branch October 4, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants