Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Set up testing configuration and create a 1st test #14 #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Testing] Set up testing configuration and create a 1st test #14 #29

wants to merge 4 commits into from

Conversation

jasonsrogers
Copy link
Contributor

@jasonsrogers jasonsrogers commented May 28, 2023 •
edited

Adding react native testing library to project to enable unit and integration testing using jest and testing library.

Implementation follow expo testing guide

File structure chosen for is to keep test close to implementation by adding sub folders __tests__ in each directory.

src
  components
    button.js
    __tests__
      button.test.js

@jasonsrogers jasonsrogers mentioned this pull request May 28, 2023
Open
@Vcky4
Copy link
Collaborator

Vcky4 commented May 28, 2023

did all the tests pass?

@jasonsrogers
Copy link
Contributor Author

jasonsrogers commented May 29, 2023 •
edited

Hi @Vcky4

The simple tests of I wrote for Wallet pass (green), but I've not figured out Register yet (yellow). The rest shows rest as there is no coverage yet

Screenshot 2023-05-29 at 10 37 17

So I can remove the Register test for this PR and we would have a working framework with passing tests for Wallet

@jasonsrogers jasonsrogers changed the title [Testing][WIP] Set up testing configuration and create a 1st test #14 [Testing] Set up testing configuration and create a 1st test #14 May 29, 2023
@Vcky4
Copy link
Collaborator

Vcky4 commented May 29, 2023

resolve the conflict and update the PR please

@Vcky4
Copy link
Collaborator

Vcky4 commented May 30, 2023

also move this pr to a new branch please

@jasonsrogers
Copy link
Contributor Author

also move this pr to a new branch please

Not sure what you mean @Vcky4, the PR is already from jasonsrogers:setup-testing to JiggyDevs:master

@Vcky4 Vcky4 linked an issue May 30, 2023 that may be closed by this pull request
Set up testing configuration and create a 1st test #14
Open
@Vcky4
Copy link
Collaborator

Vcky4 commented May 30, 2023 •
edited

please resolve the conflict in your code editor by pulling from master

@jasonsrogers
Copy link
Contributor Author

Rebased but need to update the test (will do it when I get some spare time)

@Vcky4
Copy link
Collaborator

Vcky4 commented May 30, 2023

Alright
let me know if you like me to merge

Thanks and well done

@jasonsrogers
Copy link
Contributor Author

@Vcky4 should be all good now

Followup task would be to run again PRs with a github action (but you need the rights to see the workflow)

@Vcky4
Copy link
Collaborator

Vcky4 commented May 31, 2023

This branch is not available in JiggyDevs/twikkl-app
it appears to be a pull request from a forked repo which makes me unable to fix the merge conflict, please fix the conflict and push again.

@jasonsrogers
Copy link
Contributor Author

Will do
I see that package-lock.json has been replaced by yarn-lock.json so it's probably the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up testing configuration and create a 1st test
2 participants
@jasonsrogers @Vcky4