Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): added salt prefix to check connectivity #1599

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

mortezabahrami
Copy link
Contributor

The checkConnectivity method didn't check for salt prefixes, so the connection would never get established in countries where Outline doesn't work without a salt prefix.

@mortezabahrami mortezabahrami requested a review from a team as a code owner March 12, 2023 05:03
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for your contribution.

@daniellacosse @jyyi1 we'll need another Electron client release to get this out.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (c736f8d) 35.95% compared to head (0dce05f) 35.95%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   35.95%   35.95%           
=======================================
  Files          45       45           
  Lines        2506     2506           
  Branches      308      308           
=======================================
  Hits          901      901           
  Misses       1605     1605           
Flag Coverage Δ
apple 2.27% <ø> (ø)
ios 2.30% <ø> (ø)
macos 2.29% <ø> (ø)
unittests 35.95% <ø> (ø)
www 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyyi1 jyyi1 changed the title added salt prefix to check connectivity fix(electron): added salt prefix to check connectivity Mar 13, 2023
@fortuna fortuna merged commit 644dc77 into Jigsaw-Code:master Mar 13, 2023
jyyi1 added a commit that referenced this pull request Mar 14, 2023
This hotfix fixes the connectivity test when prefix is applied: #1599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants