Rename connection to tunnel #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/electron/index.ts
Outdated
| @@ -298,26 +300,26 @@ async function startVpn( | |||
| throw new Error('already connected'); | |||
| } | |||
|
|
|||
| currentConnection = new ConnectionManager(config, isAutoConnect); | |||
| currentConnection = new TunnelManager(config, isAutoConnect); | |||
There was a problem hiding this comment.
Good catch, done in 07fcf56.
|
|
||
| ## JavaScript API | ||
|
|
||
| ```ts | ||
|
|
||
| // Represents a Shadowsocks server configuration. | ||
| interface ShadowsocksServerConfig { | ||
| interface ServerConfig { |
There was a problem hiding this comment.
Did you mean to change this name as well?
There was a problem hiding this comment.
Yes, this interface was always ServerConfig. The documentation was not in sync.
That's right. I think the abstraction fits better with networking terminology (i.e. "apps establish TCP connections over a VPN tunnel", TUN device) and native platform concepts (i.e. Apple's PacketTunnelProvider, our own Android VpnTunnelService). Thank you for the review :) |
JonathanDCohen
approved these changes
Oct 1, 2020
github-actions bot
added a commit
to Wolf1329/outline-client
that referenced
this pull request
Oct 3, 2020
* https://github.com/Jigsaw-Code/outline-client: Rename connection to tunnel (Jigsaw-Code#863)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cordova.plugin.outlineand native platform implementations.