Add stronger types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to convert dust_concentration to f64 instead of i32 to match the original type in ambi. |
jhodapp
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added stronger typing to the Reading struct. The types used were mostly dictated by the Rust to Postgresql type mapping that Diesel implements.
I removed some test that were no longer valid. I didn't replace any since I felt the type system was already doing basically the same sort of checks. If you have any suggestions on additional tests that you think should be added then let me know.
This has been tested against ambi (Elixir) and the initial implementation of ambi-rs that is still in PR. It could successfully post readings to both.