improve performance

sample_WeiboPlus/Controllers/HomeViewController.m

@@ -68,6 +68,7 @@ - (void)viewDidLoad
 {
     [super viewDidLoad];
     self.tableView.backgroundColor = [UIColor colorWithPatternImage:[Images textureBackgroundImage]];
+    self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
 }
 
 - (void)viewDidUnload

sample_WeiboPlus/Views/TweetView/TweetLayer.m

@@ -20,7 +20,7 @@ - (id)init {
         self.wrapped = YES;
         self.rasterizationScale = [[UIScreen mainScreen] scale];
         self.contentsScale = [[UIScreen mainScreen] scale];
-        //self.drawsAsynchronously = YES;
+        self.drawsAsynchronously = YES;
 
         _activeLinkBackgroundLayers = [[NSMutableArray array] retain];
     }

sample_WeiboPlus/Views/TweetView/TweetViewCell.h

@@ -19,6 +19,12 @@
     ImageDownloadReceiver *_retweetAuthorImageDownloadReceiver;
     UIImage *_tweetAuthorImage;
     UIImage *_retweetAuthorImage;
+
+    UIImage *_drawedImage;
+    BOOL _isDrawing;
+
+    CALayer *_tweetAuthorProfileImageLayer;
+    CALayer *_retweetAuthorProfileImageLayer;
 }
 @property (nonatomic, retain) TweetViewCellLayout *layout;
 

sample_WeiboPlus/Views/TweetView/TweetViewCell.m

@@ -13,15 +13,18 @@ @interface TweetViewCell() {
 
 @property (nonatomic, retain) UIImage *tweetAuthorImage;
 @property (nonatomic, retain) UIImage *retweetAuthorImage;
+@property (nonatomic, retain) UIImage *drawedImage;
 
 @end
 
 @implementation TweetViewCell
 @synthesize layout = _layout;
+@synthesize drawedImage = _drawedImage;
 
 - (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reuseIdentifier {
     self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
     if (self) {
+        contentView.backgroundColor = [UIColor whiteColor];
         _downloader = [ImageDownloader profileImagesDownloader];
         _tweetAuthorImageDownloadReceiver = [[ImageDownloadReceiver alloc]init];
         _tweetAuthorImageDownloadReceiver.completionBlock = ^(NSData *imageData, NSString *url, NSError *error) {
@@ -33,6 +36,13 @@ - (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reus
         };
         _tweetAuthorImage = nil;
         _retweetAuthorImage = nil;
+
+
+        _tweetAuthorProfileImageLayer = [self profileImageLayer];
+        _retweetAuthorProfileImageLayer = [self profileImageLayer];
+        [contentView.layer addSublayer:_tweetAuthorProfileImageLayer];
+        [contentView.layer addSublayer:_retweetAuthorProfileImageLayer];
+
     }
     return self;
 }
@@ -45,20 +55,29 @@ - (void)dealloc {
     [_retweetAuthorImageDownloadReceiver release];
     [_tweetAuthorImage release];
     [_retweetAuthorImage release];
+    [_drawedImage release];
 
     [super dealloc];
 }
 
 - (CALayer *)profileImageLayer {
     CALayer *layer = [CALayer layer];
     layer.shouldRasterize = YES;
-    //layer.frame = CGRectMake(10, 10, 34, 34);
-    layer.masksToBounds = YES;
+    layer.frame = CGRectMake(10, 10, 34, 34);
+    //layer.masksToBounds = YES;
     layer.rasterizationScale = [[UIScreen mainScreen] scale];
     layer.drawsAsynchronously = YES;
+    NSDictionary *actions = [[NSDictionary alloc] initWithObjectsAndKeys:[NSNull null], @"contents", nil];
+    layer.actions = actions;
+    [actions release];
     return layer;
 }
 
+- (void)resetProfileImageLayers {
+    _tweetAuthorProfileImageLayer.contents = (id)[self profileHolderImage].CGImage;
+    _retweetAuthorProfileImageLayer.contents = (id)[self profileHolderImage].CGImage;
+}
+
 - (void)setLayout:(TweetViewCellLayout *)layout {
     if (_layout != layout) {
         [_downloader removeDelegate:_tweetAuthorImageDownloadReceiver forURL:_layout.status.user.profileImageUrl];
@@ -67,8 +86,18 @@ - (void)setLayout:(TweetViewCellLayout *)layout {
         }
         self.tweetAuthorImage = nil;
         self.retweetAuthorImage = nil;
+        _isDrawing = NO;
+        self.drawedImage = nil;
+        [self performSelectorInBackground:@selector(resetProfileImageLayers) withObject:nil];
         [_layout release];
         _layout = [layout retain];
+
+        [CATransaction begin];
+        [CATransaction setAnimationDuration:0];
+        _tweetAuthorProfileImageLayer.frame = _layout.tweetAuthorProfileImageRect;
+        _retweetAuthorProfileImageLayer.frame = _layout.retweetAuthorProfileImageRect;
+        [CATransaction commit];
+
         [_downloader activeRequest:_layout.status.user.profileImageUrl delegate:_tweetAuthorImageDownloadReceiver];
         if (_layout.status.retweetedStatus) {
             [_downloader activeRequest:_layout.status.retweetedStatus.user.profileImageUrl delegate:_retweetAuthorImageDownloadReceiver];
@@ -82,9 +111,9 @@ - (void)setLayout:(TweetViewCellLayout *)layout {
 - (UIImage *)processImageData:(NSData *)imageData rect:(CGRect)rect {
     UIImage *image = [UIImage imageWithData:imageData];
     if (image) {
-        float scale = [[UIScreen mainScreen] scale];
-        CGRect bounds = CGRectMake(0, 0, rect.size.width * scale, rect.size.height * scale);
-        UIGraphicsBeginImageContext(bounds.size);
+        CGRect bounds = rect;
+        bounds.origin = CGPointZero;
+        UIGraphicsBeginImageContextWithOptions(bounds.size, YES, 0);
         //CGContextRef c = UIGraphicsGetCurrentContext();
         //CGContextScaleCTM(c, scale, scale);
 
@@ -102,9 +131,9 @@ - (UIImage *)profileHolderImage {
         UIImage *image = [Images profilePlaceholderOverWhiteImage];
         if (image) {
             CGRect rect = _layout.tweetAuthorProfileImageRect;
-            float scale = [[UIScreen mainScreen] scale];
-            CGRect bounds = CGRectMake(0, 0, rect.size.width * scale, rect.size.height * scale);
-            UIGraphicsBeginImageContext(bounds.size);
+            CGRect bounds = rect;
+            bounds.origin = CGPointZero;
+            UIGraphicsBeginImageContextWithOptions(bounds.size, NO, 0);
             //CGContextRef c = UIGraphicsGetCurrentContext();
             //CGContextScaleCTM(c, scale, scale);
 
@@ -119,14 +148,32 @@ - (UIImage *)profileHolderImage {
 
 }
 
+- (void)displayProfileImages {
+    if (!_isDrawing) {
+        if (self.tweetAuthorImage) {
+            [_tweetAuthorProfileImageLayer performSelectorInBackground:@selector(setContents:) withObject:(id)self.tweetAuthorImage.CGImage];
+        }
+        if (self.retweetAuthorImage) {
+            [_retweetAuthorProfileImageLayer performSelectorInBackground:@selector(setContents:) withObject:(id)self.retweetAuthorImage.CGImage];
+        }
+    }
+
+}
+
 - (void)processTweetAuthorImageData:(NSData *)imageData {
     self.tweetAuthorImage = [self processImageData:imageData rect:_layout.tweetAuthorProfileImageRect];
-    [self setNeedsDisplayInRect:_layout.tweetAuthorProfileImageRect];
+    //_tweetAuthorProfileImageLayer.contents = (id)self.tweetAuthorImage.CGImage;
+    [self displayProfileImages];
+    //self.drawedImage = nil;
+    //[self setNeedsDisplayInRect:_layout.tweetAuthorProfileImageRect];
 }
 
 - (void)processRetweetAuthorImageData:(NSData *)imageData {
     self.retweetAuthorImage = [self processImageData:imageData rect:_layout.retweetAuthorProfileImageRect];
-    [self setNeedsDisplayInRect:_layout.retweetAuthorProfileImageRect];
+    //_retweetAuthorProfileImageLayer.contents = (id)self.retweetAuthorImage.CGImage;
+    [self displayProfileImages];
+    //self.drawedImage = nil;
+    //[self setNeedsDisplayInRect:_layout.retweetAuthorProfileImageRect];
 }
 
 - (void)receiver:(ImageDownloadReceiver *)receiver didDownloadWithImageData:(NSData *)imageData
@@ -144,41 +191,71 @@ - (void)receiver:(ImageDownloadReceiver *)receiver didDownloadWithImageData:(NSD
     }
 }
 
-- (void)drawContentView:(CGRect)rect highlighted:(BOOL)highlighted {
-    CGContextRef context = UIGraphicsGetCurrentContext();
+- (void)drawOnImage {
+    if (!_isDrawing) {
+        _isDrawing = YES;
+        UIImage *image = nil;
+        CGRect bounds = self.bounds;
+        UIGraphicsBeginImageContextWithOptions(bounds.size, YES, 0);
+        CGContextRef context = UIGraphicsGetCurrentContext();
+        [self drawContentInContext:context];
+        image = UIGraphicsGetImageFromCurrentImageContext();
+        UIGraphicsEndImageContext();
+        self.drawedImage = image;
+        [self performSelectorOnMainThread:@selector(setNeedsDisplay) withObject:nil waitUntilDone:NO];
+        _isDrawing = NO;
+        [self displayProfileImages];
+    }
+}
+
+- (void)drawContentInContext:(CGContextRef)context {
     [[Images tweetOuterBackgroundImage]drawInRect:self.bounds];
     if (_layout.status.retweetedStatus) {
         [[Images tweetInnerBackgroundImage] drawInRect:_layout.retweetRect];
     }
     CGContextSaveGState(context);
     CGContextSetTextMatrix(context, CGAffineTransformIdentity);
 
-    CGContextTranslateCTM(context, 0.0f, rect.size.height);
+    CGContextTranslateCTM(context, 0.0f, self.bounds.size.height);
     CGContextScaleCTM(context, 1.0f, -1.0f);
-
+    
     [_layout.tweetDocument drawTextInRect:self.bounds textRect:_layout.tweetTextRect context:context];
     [_layout.tweetAuthorDocument drawTextInRect:self.bounds textRect:_layout.tweetAuthorTextRect context:context];
     if (_layout.status.retweetedStatus) {
         [_layout.retweetDocument drawTextInRect:self.bounds textRect:_layout.retweetTextRect context:context];
         [_layout.retweetAuthorDocument drawTextInRect:self.bounds textRect:_layout.retweetAuthorTextRect context:context];
     }
     CGContextRestoreGState(context);
-
+    
     CGContextSaveGState(context);
     CGContextSetRGBFillColor(context, 187/255.f, 187/255.f, 187/255.f, 1.f);
 
     NSString *timeText = [NSString stringWithFormat:@"%@・%@", [_layout.status statusTimeString], [_layout.status source]];
     [timeText drawInRect:_layout.tweetTimeTextRect withFont:[Fonts statusTimeFont]];
-    UIImage *profileImage = self.tweetAuthorImage ? self.tweetAuthorImage : [self profileHolderImage];
-    [profileImage drawInRect:_layout.tweetAuthorProfileImageRect];
+    //UIImage *profileImage = self.tweetAuthorImage ? self.tweetAuthorImage : [self profileHolderImage];
+    //[profileImage drawInRect:_layout.tweetAuthorProfileImageRect];
     if (_layout.status.retweetedStatus) {
         timeText = [NSString stringWithFormat:@"%@・%@", [_layout.status.retweetedStatus statusTimeString], [_layout.status.retweetedStatus source]];
         [timeText drawInRect:_layout.retweetTimeTextRect withFont:[Fonts statusTimeFont]];
-        profileImage = self.retweetAuthorImage ? self.retweetAuthorImage : [self profileHolderImage];
-        [profileImage drawInRect:_layout.retweetAuthorProfileImageRect];
+        //profileImage = self.retweetAuthorImage ? self.retweetAuthorImage : [self profileHolderImage];
+        //[profileImage drawInRect:_layout.retweetAuthorProfileImageRect];
     }
     CGContextRestoreGState(context);
 }
 
+- (void)drawContentView:(CGRect)rect highlighted:(BOOL)highlighted {
+    CGContextRef context = UIGraphicsGetCurrentContext();
+    [self drawContentInContext:context];
+    /*
+    [[Images tweetOuterBackgroundImage]drawInRect:self.bounds];
+    if (self.drawedImage) {
+        [self.drawedImage drawInRect:self.bounds];
+    }
+    else {
+        [self performSelectorInBackground:@selector(drawOnImage) withObject:nil];
+    }
+     */
+}
+
 
 @end

sample_WeiboPlus/Views/TweetView/TweetViewCell1.h

@@ -0,0 +1,40 @@
+//
+//  TweetViewCell1.h
+//  WeiboPlus
+//
+//  Created by junmin liu on 12-11-21.
+//  Copyright (c) 2012年 idfsoft. All rights reserved.
+//
+
+#import "ABTableViewCell.h"
+#import "TweetViewCellLayout.h"
+#import "ImageDownloader.h"
+#import "ImageDownloadReceiver.h"
+#import "Images.h"
+#import "TweetLayer.h"
+
+
+@interface TweetViewCell1 : ABTableViewCell {
+    TweetViewCellLayout *_layout;
+    ImageDownloader *_downloader;
+    ImageDownloadReceiver *_tweetAuthorImageDownloadReceiver;
+    ImageDownloadReceiver *_retweetAuthorImageDownloadReceiver;
+    UIImage *_tweetAuthorImage;
+    UIImage *_retweetAuthorImage;
+
+
+    CALayer *_tweetAuthorProfileImageLayer;
+    CALayer *_retweetAuthorProfileImageLayer;
+
+    TweetLayer *_tweetTextLayer;
+    TweetLayer *_retweetTextLayer;
+    TweetLayer *_tweetAuthorLayer;
+    TweetLayer *_retweetAuthorLayer;
+    CATextLayer *_tweetTimeLayer;
+    CATextLayer *_retweetTimeLayer;
+}
+
+@property (nonatomic, retain) TweetViewCellLayout *layout;
+
+
+@end