Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresco 3.1.3 compatibility issues with RN 0.73.0, react-native-image-marker:compileDebugKotlin FAILED #176

Closed
JimmyDaddy opened this issue Dec 19, 2023 Discussed in #175 · 3 comments · Fixed by #177
Closed
Assignees
Labels
Milestone

Comments

@JimmyDaddy
Copy link
Owner

Discussed in #175

Originally posted by Tiepbm December 15, 2023
Describe the bug
e: file:///Users/tiepbm/Desktop/TiepBM/PVI/PVI247/node_modules/react-native-image-marker/android/src/main/java/com/jimmydaddy/imagemarker/ImageLoader.kt:140:34 Type mismatch: inferred type is ImagePipelineExperiments but ImagePipelineConfig? was expected
Uploading image.png…

Devlopment environment(please complete the following information):

  • OS: Mac M1
  • nodejs: 21.2.0
  • react-native: 0.73.0
  • react-native-image-marker : 1.1.10

Smartphone (please complete the following information):

  • Device:SamSung S22
  • OS: Android 12

thanks!

Originally posted by JimmyDaddy December 19, 2023

I have found the real cause of this problem, RN <= 0.73.0 uses fresco version is 2.xx.x
But 0.73.0 uses 3.1.3.
It seems ImagePipelineConfig.newBuilder(context).experiment().setMaxBitmapSize(int).build() return ImagePipelineExperiments instead of ImagePipelineConfig now.
Sorry for that, I'll update a fix ASAP to adapt the 0.73.x

@Tiepbm
Copy link

Tiepbm commented Dec 21, 2023

@JimmyDaddy Can I ask when will you release the new version?
thanks,

@JimmyDaddy
Copy link
Owner Author

JimmyDaddy commented Dec 21, 2023

@JimmyDaddy Can I ask when will you release the new version? thanks,

@Tiepbm
I'll release a minor version, 1.2.0, after I fixed #179 today

@Tiepbm
Copy link

Tiepbm commented Dec 21, 2023

@JimmyDaddy Can I ask when will you release the new version? thanks,

@Tiepbm I'll release a minor version, 1.2.0, after I fixed #179 today

thanks!

@JimmyDaddy JimmyDaddy self-assigned this Dec 21, 2023
@JimmyDaddy JimmyDaddy added the bug label Dec 21, 2023
@JimmyDaddy JimmyDaddy added this to the 1.2.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants