No dataset created when path contains spaces #122
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
In #118 we introduced a bug in this line:
jailmaker/jlmkr.py
Line 930 in 9661f4f
It does not compare as intended in case one of the parent datasets (and possible the pool name) contain spaces:
The contents of
/proc/mounts
contain the paths with spaces encoded as discussed in openzfs/zfs#11182.Which results in us doing this comparison:
The comparison fails and we end up not creating datasets, but plain directories for new jails.
@templehasfallen FYI
Reproduction steps
jlmkr.py
file in thejailmaker
dir and runjlmkr.py create test
.jailmaker
dataset.Impact
The impact is relatively low as TrueNAS GUI doesn't allow creating datasets with spaces in their name. However datasets created with spaces by using the cli will show up fine in the TrueNAS GUI. So jailmaker needs to support this too.
The text was updated successfully, but these errors were encountered: