Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with 222.* #5

Merged
merged 1 commit into from Sep 12, 2022
Merged

Conversation

lilithium-hydride
Copy link
Contributor

I don't know how to (or if I even can) run the theme compatibility checker myself, so apologies if there's more work to be done than a simple version number bump.

Add compatibility with newer IDE versions
@Jmorjsm
Copy link
Owner

Jmorjsm commented Jul 16, 2022

Thank you for this! I'm away right now but I'll see what I can do to review this on Sunday!

@Jmorjsm
Copy link
Owner

Jmorjsm commented Jul 19, 2022

It looks like we have two options for this, upload a compiled version of the plugin to the marketplace page on the JetBrains website:
image
Or, try using this GitHub action https://github.com/marketplace/actions/intellij-plugin-verifier. I'll try enabling this now.

@Jmorjsm Jmorjsm merged commit 1699983 into Jmorjsm:main Sep 12, 2022
@Jmorjsm
Copy link
Owner

Jmorjsm commented Sep 12, 2022

I've built and tested this locally and it's working. The updated build has been uploaded to JetBrains marketplace and is awaiting approval.

I'll create another issue to automate the validation of this & create an artifact with the plugin .jar file to be uploaded to the marketplace.

Thanks again for this, @lilithium-hydride, and sorry I took so long to validate it!

@lilithium-hydride
Copy link
Contributor Author

No worries, I'm glad it's working! I agree that automation is the best way forward with this, since Jetbrains' programs care so much about version numbers instead of looking at API differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants