Add support for directly deserializing Guava immutable collections #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As written, the implementation changes the serialized format, by writing out "meta-type" strings. This seems undesirable, as I'd like to keep the serialized format stable if possible. However, there is no problem that I can see with the deserialization part of the change, which uses the meta property information to create an object of the correct type. |
|
See if the better-deser branch works for you. |
|
Yes, it works nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit support for
ImmutableList,ImmutableSet,ImmutableSortedSetandImmutableMap. This allows objects to be serialized using custom meta beans which use the deserialized value to populate the field without any copying.Fixes #129