Fix for referencing bean format using incorrect class name with JodaConvert interfaces #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodastephen
reviewed
May 8, 2019
|
|
||
| final class First implements JodaConvertInterface { | ||
|
|
||
| static final First instance = new First(); |
|
|
||
| final class Second implements JodaConvertInterface { | ||
|
|
||
| static final Second instance = new Second(); |
I'll add the same test for the other serializers, but in the instance that you cannot determine the type from the bean (as in the test they're a map value of type Object) then the interface name is serialized for the binary, xml, and json writers. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one serializes an immutable bean which holds under an Object reference something implementing a JodaConvert interface with multiple implementations and the type is required to be serialized then the referencing converter chooses to serialize the first concrete implementation class name it encounters, rather than that of the interface itself.
Added a test case for it and deleted some useless code (we don't care about serializing class names for null values; also serializing classes as values is easy, just write the class name!)