add libdcrwallet dependency with few implemented methods #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
reviewed
Nov 9, 2023
JoeGruffins
reviewed
Nov 9, 2023
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
9907980
to
232ea5e
Compare
itswisdomagain
commented
Nov 9, 2023
JoeGruffins
reviewed
Nov 9, 2023
JoeGruffins
reviewed
Nov 9, 2023
JoeGruffins
reviewed
Nov 9, 2023
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
eedaa19
to
583ff18
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
2 times, most recently
from
b65ff0a
to
eef0db7
Compare
itswisdomagain
commented
Nov 11, 2023
itswisdomagain
force-pushed
the
dcrlibwallet
branch
3 times, most recently
from
3ed002d
to
6ed9ab5
Compare
dreacot
reviewed
Nov 16, 2023
dreacot
reviewed
Nov 16, 2023
dreacot
reviewed
Nov 16, 2023
dreacot
reviewed
Nov 16, 2023
dreacot
reviewed
Nov 16, 2023
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
6ed9ab5
to
53bd705
Compare
JoeGruffins
force-pushed
the
cw-decred
branch
from
a57e019
to
6c1843d
Compare
JoeGruffins
force-pushed
the
cw-decred
branch
from
6c1843d
to
6151bb7
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
53bd705
to
48e1437
Compare
JoeGruffins
force-pushed
the
cw-decred
branch
from
6151bb7
to
5c18d35
Compare
JoeGruffins
reviewed
Dec 19, 2023
JoeGruffins
force-pushed
the
cw-decred
branch
from
5c18d35
to
77fcd84
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
2 times, most recently
from
13fbbde
to
027fd55
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
2 times, most recently
from
2cb10e8
to
7c9afc1
Compare
JoeGruffins
reviewed
Dec 21, 2023
itswisdomagain
commented
Dec 21, 2023
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
849750a
to
661b2df
Compare
JoeGruffins
force-pushed
the
cw-decred
branch
from
77fcd84
to
4825ea1
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
661b2df
to
61f398c
Compare
JoeGruffins
reviewed
Feb 5, 2024
| rm -fr $LIBWALLET_PATH | ||
| fi | ||
| mkdir -p $LIBWALLET_PATH | ||
| git clone $LIBWALLET_URL $LIBWALLET_PATH --branch cgo |
There was a problem hiding this comment.
I think this should point at the specific commit that this pr should work on. That is possible right? e1b9f6043359d191cfd2fbfaa345396a009d0946
In case we make a breaking change, which I think is fine at this point.
There was a problem hiding this comment.
Yeah, this makes a lot of sense.
|
closing because merged with decred_main upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build steps now include fetching the libwallet go source code from https://github.com/itswisdomagain/libwallet/tree/cgo and generating the appropriate library for the target OS.