argparse & logging #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commands, stub logging
- use logging instead of flog for non-extern modules - use WHIPPER_DEBUG and WHIPPER_LOGFILE env variables
- Convert log.* calls to logger.* - Remove morituri.common.log imports
- inline into __init__ - throw IOError instead of Exception for missing drives - remove CommandError checking in rip/main
- remove command.CommandError occurrences - remove python-command external module
- mv common.command to command.basecommand - move TEMPLATES used only by rip.cd out of rip.common - update entry point for command to command.main
|
I don't know if it's required, but I am ACKing the suggested changes. A squash-merge indeed seems like the proper merge here. (@JoeLametta: Let me know if you need help with that) |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend squash merging, just keeping the commit history in the merge commit.
There should be no major behaviour changes for command parsing, but
RIP_DEBUGhas been replaced withWHIPPER_DEBUGand takes python standard logging levels (e.g., "DEBUG", "INFO") as its argument instead of an arbitrary number.WHIPPER_LOGFILEhas been introduced so logging isn't intermixed with stderr messages unless the user opts in with2>. The default is to log to stderr at level 'WARNING' & above (the unused 'ERROR' and 'CRITITCAL').The semantics between WARNING and ERROR levels are not well explored in the code, and there are some sections that should use logging that don't. Future work should address this.