Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for WOTR 2.3, Reduce manual steps for build #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

evandixon
Copy link

@evandixon evandixon commented Jun 14, 2024

Fixes #199 hopefully

  • Update to .Net 4.8.1 for compatibility with the latest Tabletop Tweaks Core and 0Harmony
  • Fix broken references from WOTR update. TBH I'm a little unsure these are fully correct, but it builds at least. More testing is required.
    • Extra summon count: Updated "unit" to "mechanicsContext.MaybeCaster"
    • Weapon stat damage replacement. Credit to @darinclark for providing the code to handle two-handed weapons in one hand.
  • Remove requirement to manually copy files around when building/testing
    • Update png files to copy to output on build
    • Add deathsnatcher portraits

This PR was made somewhat hastily with the goal of getting it running. Idk if anything else broke with the WOTR 2.3 update. Here's a custom build of this PR in case anyone is willing to help test or simply doesn't want to wait for the PR to be merged.
IsekaiMod.zip
If you wish to test, please pay special attention to the summon count increase and the archetype that uses CHA for weapon damage, especially for two-handed weapons.

[Edit]
New version fixing two-handed weapons in one hand:
IsekaiMod.zip

@evandixon
Copy link
Author

evandixon commented Jun 14, 2024

Now that I think about it, having the user settings files copy to output will reset user settings when the mod is installed. Making them not copy to the output should fix that. The original readme saying to manually put them there is why I did that, but I guess it wasn't needed with the embedded resource thing.
[Edit] Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game won't launch after patch
1 participant