-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting (decrypting?) 6.3x PSARs is frigging slow #14
Comments
Did some quick profiling:
6.61:
So, 2x the magnitude of bignum operations. I bet something weird is going on with how we enumerate files causing us to visit files multiple times? Might need to instrument things to figure it out. To reproduce:
|
bignum functions are only used for ECDSA checking IIRC, was ECDSA checking enabled for all modules in 6.3x but removed in 6.6x? |
I tried commenting ecdsa_verify, and indeed it becomes a lot faster. It could probably be disabled by default since I doubt it's functional anyway. |
Might be nice to add a flag to enable that behavior and have it disabled by default? |
Yep, related to #13, I'm even considering disabling it for now as I doubt it works... |
Why???
The text was updated successfully, but these errors were encountered: