Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple exetype options need to be enclosed in quotes #28

Closed
midwan opened this issue Oct 18, 2022 · 1 comment · Fixed by #31
Closed

Multiple exetype options need to be enclosed in quotes #28

midwan opened this issue Oct 18, 2022 · 1 comment · Fixed by #31
Assignees

Comments

@midwan
Copy link
Contributor

midwan commented Oct 18, 2022

Thanks for the excellent work with this project! :)

I noticed that the tasks.json example does not quite work as-is, at least not for me (I'm using Powershell as the default terminal, but I also tried the cmd one, and got the same result).
The multiple platforms specification are separated by a pipe character (|), but Powershell interprets that and it fails, unless the whole thing is enclosed in quotes.

For example, this fails:
-exetype win32|win64

with the following error message:

win64: The term 'win64' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

but doing it like this, works:
-exetype "win32|win64"

Accordingly, the tasks.json example in your documentation could be updated as follows:

        {
            "label": "Compile the currently opened Hollywood file to multiple targets ",
            "type": "shell",
            "command": "${config:hollywood.exePath}",
            "args": [
                "${file}",
                "-compile",
                "${fileBasenameNoExtension}",
                "-exetype",
                "'win32|win64|classic|morphos'"
            ]
        }

To ensure it works - I've only enclosed those options with a single quote.

Hope this helps!

@JohnArcher JohnArcher self-assigned this Nov 22, 2022
@JohnArcher
Copy link
Owner

Hey @midwan , thanks a lot for your contribution! I will check this in detail later, I just wanted to get back to you and say sorry for my late response. I don't know what the problem is, but I don't get email notifications for new issues, just if someone replys to existing ones etc. So I found you issue by accident now. :-(

@JohnArcher JohnArcher linked a pull request Dec 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants