Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with upcoming countrycode version #527

Closed
vincentarelbundock opened this issue May 30, 2023 · 2 comments
Closed

Error with upcoming countrycode version #527

vincentarelbundock opened this issue May 30, 2023 · 2 comments

Comments

@vincentarelbundock
Copy link

I am the countrycode maintainer and will release a new minor version soon. There are no breaking changes, and I did not expect any breakage in downstream packages. However, when doing reverse dependency checks, I ran into an error in the echarts4r test suite.

Pasting the error below to inform you:

Changes to worse in reverse depends:

Package: echarts4r
Check: tests
New result: ERROR
    Runningtestthat.R’ [4s/4s]
  Running the tests intests/testthat.Rfailed.
  Complete output:
> library(testthat)
> library(echarts4r)
> 
> test_check("echarts4r")
    [ FAIL 1 | WARN 14 | SKIP 0 | PASS 180 ]
    
    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-map.R:21:3'): e_map plot has the good data structure and type ──
    plot$x$opts$series[[1]]$data not equal to list(...).
    Component 2: Component 2: 1 string mismatch
    Component 3: Component 2: 1 string mismatch
    Component 4: Component 2: 1 string mismatch
    Component 5: Component 2: 1 string mismatch
    
    [ FAIL 1 | WARN 14 | SKIP 0 | PASS 180 ]
    Error: Test failures
    Execution halted
@JohnCoene
Copy link
Owner

Thank you, got email from CRAN too. Will fix.

@munoztd0
Copy link
Collaborator

munoztd0 commented Jun 8, 2023

Commit b1eac68 fixed this

@munoztd0 munoztd0 closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants