New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e_mark_point() use exact matching for the serie param #81

Merged

JohnCoene merged 1 commit into JohnCoene:master from shrektan:fix-grep

Jun 7, 2019

Contributor

shrektan commented Jun 7, 2019

Closes #80

After the PR, the below two examples work as expected.

library(echarts4r)
x <- data.frame(a = 1:10, b = 1:10)
e_chart(x, 'a') %>%
  e_line('b', name = 'aa(bb)', smooth = TRUE, symbol = 'none') %>%
  e_mark_point('aa(bb)', data = list(xAxis = 5, yAxis = 5, value = 5))

library(echarts4r)
x <- data.frame(a = 1:10, b = 1:10, c = 1:20)
e_chart(x, 'a') %>%
  e_line('b', name = 'abcdefg', smooth = TRUE, symbol = 'none') %>%
  e_line('c', name = 'abcd', smooth = TRUE, symbol = 'none') %>%
  e_mark_point('abcd', data = list(xAxis = 5, yAxis = 5, value = 5))


          Closes JohnCoene#80: No longer uses grep() in .get_index()

e072fd7

JohnCoene merged commit bcc099f into JohnCoene:master

Owner

JohnCoene commented Jun 7, 2019

Thank you for this, it makes indeed much more sense! I do not why I had used grep before.

shrektan deleted the fix-grep branch

June 7, 2019 13:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment