Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sever disconnected screen doesn't hide tooltip info #4

Open
etiennebacher opened this issue Aug 12, 2020 · 2 comments
Open

sever disconnected screen doesn't hide tooltip info #4

etiennebacher opened this issue Aug 12, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@etiennebacher
Copy link

I have a plot made with {echarts4r} that uses a tooltip to display info. I also use sever() to customize the disconnected screen. However, when the session is disconnected, the custom screen is displayed but I can also see the tooltip info of the plot previously displayed.

Example:

library(shiny)
library(sever)
library(echarts4r)

ui <- fluidPage(
  use_sever(),
  echarts4rOutput("test_plot")
)

server <- function(input, output){
  sever()
  
  output$test_plot <- renderEcharts4r({
    cor(mtcars) %>% 
      e_charts() %>% 
      e_correlations(
        order = "hclust",
        visual_map = FALSE
      ) %>% 
      e_visual_map(
        min = -1, 
        max = 1
      ) %>%
      e_tooltip()
  })
  
}

shinyApp(ui, server)

Reproduce:

  • run the app in external window
  • open in browser (button at the top of the external window)
  • close the external window. This will display the disconnected screen in browser.
  • move the mouse on the disconnected screen. The tooltip info is displayed whereas it shouldn't be.

If it matters, I use Firefox as browser.

@JohnCoene JohnCoene added the enhancement New feature or request label Aug 12, 2020
@JohnCoene
Copy link
Owner

I had not noticed, this can be fixed. I'll do that when I find the time.

@etiennebacher
Copy link
Author

etiennebacher commented Oct 17, 2020

I guess this has to do with CSS. I've seen that, when the disconnected screen appears, there are two elements: severed and shiny-disconnected-overlay. When hovering severed, the tooltip info of the echarts plot is not shown, as if severed was completely overlapping the plot. However, when hovering shiny-disconnected-overlay, the tooltip info appears. Therefore, I tried to apply the CSS rules of severed to shiny-disconnected-overlay but without success.

Another idea might be to modify/add a CSS class when the disconnected screen is displayed but I don't know how to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants