Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding infinite capability to Hostess #65

Closed
MalditoBarbudo opened this issue Oct 2, 2020 · 2 comments
Closed

Adding infinite capability to Hostess #65

MalditoBarbudo opened this issue Oct 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@MalditoBarbudo
Copy link
Contributor

Hi @JohnCoene
I've been toying a little with implementing infinite capabalitiy to Hostess class, you can see it here:
https://github.com/MalditoBarbudo/waiter/tree/hostess_infinite
At the moment, only the simplest case is working (it was just a proof of concept, so is not closing). You can check the branch code with a slight modification of your provided example:

library(shiny)
library(waiter)

ui <- fluidPage(
  use_hostess(), # include dependencies
  hostess_loader("load", text_color = "black", center_page = TRUE)
)

server <- function(input, output){
  
  # initialise
  hostess <- Hostess$new("load", infinite = TRUE)
  hostess$start()
  
  # # increment
  # for(i in 1:10){
  #   Sys.sleep(runif(1)) # random sleep
  #   hostess$set(i * 10)
  # }
}

shinyApp(ui, server)

Before continuing, I would like to ask you some questions:

  • I think it would be a nice addition, as the Hostess class have a lot of styles customizations that can be used, but lack of infinite option, thus making it not so good when you can not compute steps. But, do you think is worthy to implement it?
  • In case is worthy, am I going in the correct way? or do you have another approach that would be better?
  • Finally, do you want to me continue trying to develop this for all Hostess modes (several ids, notifications....)? I can use some spare time to delve deeper on this if you think is a good idea 😉
@JohnCoene
Copy link
Owner

Hi @MalditoBarbudo !

Thank you for this: an infinite argument with the hostess would be more than welcome! Feel free to create a pull request

@JohnCoene JohnCoene added enhancement New feature or request hacktoberfest labels Oct 3, 2020
@JohnCoene
Copy link
Owner

@MalditoBarbudo FYI: I've tagged this repo as valid for hacktoberfest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants