logging events

[fmmattioni]

Hey @JohnCoene!

While debugging an app using the latest version of {waiter}, I have noticed that waiter.js has been logging the shiny events to the console:

waiter/inst/assets/waiter/waiter.js

Lines 184 to 190 in 003795d

	// remove when output receives value
	$(document).on('shiny:value', function(event) {
	console.log(event);
	if(waiter_to_hide.indexOf(event.name) > 0){
	hide_waiter(event.name);
	}
	});

Just wondering if this is intended?

[JohnCoene]

Thanks! I removed it.

[trafficonese]

Here is another one. ;)

waiter/R/waiter.R

Line 235 in 477789d

console.log('idle');

The app also always starts with this message:
waiter_show_on_load - shiny not connected yet: Shiny.setInputValue is not a function

[JohnCoene]

Thanks, I removed the console.log('idle')

I placed the second message on purpose; it's good to know I think because we need waiter_show_on_load to run before shiny connects in order to avoid having app content flash before the loading screen shows. Therefore with that function the event cannot be send to the server (shiny is not connected yet) but there's no real way to communicate that to the user other than with a console message (to the best of my knowledge).

waiter/inst/assets/waiter/waiter.js

Line 121 in 322df53

console.log("waiter_show_on_load - shiny not connected yet:", err.message);