Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hooks #4

Merged
merged 5 commits into from Feb 10, 2022
Merged

Refactor hooks #4

merged 5 commits into from Feb 10, 2022

Conversation

JohnFTitor
Copy link
Owner

Hi there πŸ‘‹πŸ»

Thanks for taking the time to review the project.

Now into the project...

Changes implemented in "refactor-hooks" branch

  • βœ… Change all components of the Calculator app from class-based to functional-based.
  • βœ… Use hooks to handle states in functional components.
  • βœ… Use ES6 syntax for function declaration.
  • βœ… Use lifting state up to update the Calculator object.

Final notes

Is expected that this project meets the requirements. Please let us know if anything is left to be done or can be improved. Again, thanks for the review.

@JohnFTitor JohnFTitor added the enhancement New feature or request label Feb 10, 2022
@JohnFTitor JohnFTitor self-assigned this Feb 10, 2022
Copy link

@Cathella Cathella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯ Status: Approved 🟒

Hi @JohnFTitor πŸ‘‹πŸ»,

You have done a very good job refactoring from a class-based component to a functional component using hooks πŸ’ͺ🏻!
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

To Highlight πŸ’ͺ🏻

βœ… No linter errors.
βœ… You used correct Github Flow.
βœ… Professional README.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@JohnFTitor JohnFTitor merged commit d18c26e into dev Feb 10, 2022
@JohnFTitor JohnFTitor deleted the refactor-hooks branch February 10, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants