Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all #3

Merged
merged 3 commits into from Jan 13, 2022
Merged

Clear all #3

merged 3 commits into from Jan 13, 2022

Conversation

JohnFTitor
Copy link
Owner

Hi there πŸ‘‹πŸ»

Thanks for taking the time to review the project. Here are some things important to note about it:

Sass

The project was built using Sass. The only difference was that I needed to add an additional loader to webpack, but the result is overall the same (A CSS output). Additionally, I used MiniCssExtractPlugin to generate an external CSS file in the dist folder instead of the styles in the head of the document. It has the same dynamic response, it's just that the output looks more organized.

Now into the project...

Changes implemented in "clearAll" branch

  • βœ… My code follows the style guidelines of this project.
  • βœ… Create functions to set the status of a task object and to filter completed items from an array.
  • βœ… Add event listener to checkbox to update completed status of its task object.
  • βœ… Filter completed items and remove each of them using the same functions defined before.

Final notes

Is expected that this project meets the requirements. Please let me know if anything is left to be done or can be improved. Again, thanks for the review.

Copy link

@ShoiraTa ShoiraTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED βœ”οΈ


Hi @JohnFTitor ,

Your project is complete! Great job for nailing it right on the first attempt πŸ₯‡. There is nothing else to say other than... it's time to merge it 🍾🚒 :shipit: . Congratulations! πŸŽ‰πŸ’―πŸŒŸ

Good Points πŸ‘

  • Project is set up correctly βœ”οΈ
  • Descriptive Pull Request βœ”οΈ
  • The task object's values for completed is updated upon user actions. βœ”οΈ
  • A function for the "Clear all completed" button using the Array.filter() βœ”οΈ
  • The updated array of items is stored in local storage, so the user gets the correct list values after the page reloads. βœ”οΈ

Cheers..Happy coding!..and keep soaring higher! πŸ’» 🍷 πŸš€


As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

@JohnFTitor JohnFTitor merged commit c7fb3cb into main Jan 13, 2022
@JohnFTitor JohnFTitor deleted the clearAll branch January 13, 2022 17:14
@JohnFTitor JohnFTitor self-assigned this Feb 17, 2022
@JohnFTitor JohnFTitor added the enhancement New feature or request label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants