Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag drop #4

Merged
merged 6 commits into from Jan 13, 2022
Merged

Drag drop #4

merged 6 commits into from Jan 13, 2022

Conversation

JohnFTitor
Copy link
Owner

Hi there πŸ‘‹πŸ»

Thanks for taking the time to review the project. Here are some things important to note about it:

Sass

The project was built using Sass. The only difference was that I needed to add an additional loader to webpack, but the result is overall the same (A CSS output). Additionally, I used MiniCssExtractPlugin to generate an external CSS file in the dist folder instead of the styles in the head of the document. It has the same dynamic response, it's just that the output looks more organized.

Now into the project...

Changes implemented in "drag-drop" branch

  • βœ… My code follows the style guidelines of this project.
  • βœ… Use Drag event listeners to implement the drag functionality
  • βœ… Update list array whenever the position of the elements changed

Final notes

Is expected that this project meets the requirements. Please let me know if anything is left to be done or can be improved. Again, thanks for the review.

@JohnFTitor JohnFTitor merged commit 4154213 into main Jan 13, 2022
@JohnFTitor JohnFTitor deleted the drag-drop branch January 13, 2022 23:34
@JohnFTitor JohnFTitor self-assigned this Feb 17, 2022
@JohnFTitor JohnFTitor added the enhancement New feature or request label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant