Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--invert_hash does not work with --oaa #337

Closed
martinpopel opened this issue Jul 9, 2014 · 4 comments
Closed

--invert_hash does not work with --oaa #337

martinpopel opened this issue Jul 9, 2014 · 4 comments

Comments

@martinpopel
Copy link
Contributor

With older VW (7.4.0), the following code

    echo '1 | a b c
    3 | a d e' | vw --oaa 3 --invert_hash model.inv
    cat  model.inv

prints a nice inverted-hash model with lines like ^a:108232:0.046370. With the newest VW, it does not work (no features are printed).

@arielf
Copy link
Collaborator

arielf commented Jul 9, 2014

Hi John,

I ran a git bisect and found that this regression happened here:

=== ERROR: --oaa produced no weights readable model
d883b1ada66a4c627c4f4cd38fec8f12252b76b6 is the first bad commit
commit d883b1ada66a4c627c4f4cd38fec8f12252b76b6
Author: John Langford <jl@hunch.net>
Date:   Wed Jun 18 21:41:54 2014 -0400

    minor tweaks

Please take a look when you get a chance.

I'll try to extend RunTests to cover readable models as well soon.

@JohnLangford
Copy link
Member

This was an initialization order problem, now fixed.

-John

On 07/09/2014 03:53 PM, Ariel Faigon wrote:

Hi John,

I ran a git bisect and found that this regression happened here:

|=== ERROR: --oaa produced no weights readable model
d883b1a is the first bad commit
commit d883b1a
Author: John Langford jl@hunch.net
Date: Wed Jun 18 21:41:54 2014 -0400

 minor tweaks

|
|

Please take a look when you get a chance.

I'll try to extend RunTests to cover readable models as well soon.


Reply to this email directly or view it on GitHub
#337 (comment).

@KristianHolsheimer
Copy link
Contributor

It seems that this issue is still present when using --ftrl. Could this also be caused by a similar ordering issue?

@JohnLangford JohnLangford reopened this Sep 12, 2015
@JohnLangford
Copy link
Member

It should work for --ftrl now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants