Added Linux library Unit testing to boilerplate #20
Conversation
- Did NOT add a question about Linux support. Instead, added to Templates/ code that will still work unchanged under macOS, *OS. This is related to other details that I will describe. - do not see a conventional way to conditionally include snippets into a Template/ output file, so instead I added a conditional extension for Linux only. Snippets ability would be useful in many ways: include example unit testing code and an example object (struct, e.g.) in the Sources/ if, and only if, an optional Boolean such as "Linux Unit testing support" was added to user prompt. - tested under macOS. running `testStructure.py` passed. - compilation under Linux will fail, due to `testExample` not being defined (see above about example unit testing code)
|
This is for #17 but it is NOT the implementation as outlined there. See above for details. |
| static var allTests : [(String, ({PROJECT}Tests) -> () throws -> Void)] { | ||
| // FIXME: Should return a list of test case (name, function) tuples | ||
| return [ | ||
| ("testExample", testExample), |
There was a problem hiding this comment.
How about we just create a simple test method that does nothing, so that it compiles out of the box?
There was a problem hiding this comment.
A no-op? I like that idea. getting ready to send commit that does this.
Added test method that does nothing, so that it compiles out of the box (under Linux)
| @testable import {PROJECT}Tests | ||
|
|
||
| XCTMain([ | ||
| testCase({PROJECT}Tests.allTests), |
There was a problem hiding this comment.
🎨 Indenation is a bit off here, but I can always fix that post-merge 😄
There was a problem hiding this comment.
whoops. this was me using Emacs to insert code instead of Xcode.
There was a problem hiding this comment.
BTW, is there a linter that you know of that can spot these kind of things?
There was a problem hiding this comment.
SwiftLint seems to be quite popular in the community. Haven't tried it myself yet though (it's still on my todo list).
| #if os(Linux) | ||
| extension {PROJECT}Tests { | ||
| static var allTests : [(String, ({PROJECT}Tests) -> () throws -> Void)] { | ||
| // FIXME: Should return a list of test case (name, function) tuples |
There was a problem hiding this comment.
You can remove this now, right?
There was a problem hiding this comment.
No. That is actually needed by the way that swift test and the XCT* Framework works under Linux, at least as of today. That is also where/why the LinuxMain.swift comes in...
There was a problem hiding this comment.
Ah, sorry - I meant that we can remove the FIXME comment. We still need the array.
There was a problem hiding this comment.
Ah, OK. Sure. I will bundle the changes... (our comments crossed paths, so I deleted my earlier one)
There was a problem hiding this comment.
On the //FIXME in the templated code, I guess it's an interesting point on whether to leave it in... since this list is separately "hand" maintained for Linux testing?
I deleted it in this PR though.
|
@idcrook Ah, that's a great idea! 🚀 |
|
So I'll proceed with the merge then @idcrook? 😄 |
- Deleted the commented FIXME in the Linux test list - Formatted `LinuxMain.swift` according to conventions
|
Great stuff - thanks for doing this @idcrook! 🎉 |
|
I added a commit for the remaining review items. Ready to merge |
Did NOT add a question about Linux support. Instead, added to
Templates/ code that will still work unchanged under macOS, *OS. This
is related to other details that I will describe.
do not see a conventional way to conditionally include snippets into
a Template/ output file, so instead I added a conditional extension
for Linux only. Snippets ability would be useful in many ways:
include example unit testing code and an example object (struct,
e.g.) in the Sources/ if, and only if, an optional Boolean such as
"Linux Unit testing support" was added to user prompt.
tested under macOS. running
testStructure.pypassed.compilation under Linux will fail, due to
testExamplenot beingdefined (see above about example unit testing code)