Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Release Assets for all StyLua variants #103

Open
JohnnyMorganz opened this issue Apr 7, 2021 · 0 comments
Open

Build Release Assets for all StyLua variants #103

JohnnyMorganz opened this issue Apr 7, 2021 · 0 comments
Labels
ci Related to build/test/release workflows extension Concerns the VSCode extension
Milestone

Comments

@JohnnyMorganz
Copy link
Owner

JohnnyMorganz commented Apr 7, 2021

We currently build release assets with all flags enabled (both luau and lua52). At the moment, this is fine, as there is no conflicting syntax between the two. The GitHub release assets are what are used for the VSCode extension, so the VSCode has all of this enabled.

We should create release assets for all variants individually (currently: lua51 [default], luau and lua52). We can then add a configuration option in the VSCode extension, to select which variant we want to use. Creating these release assets also means its easier for other users to quickly retrieve the variant they want from the releases page.

Need to see how this conflicts with https://github.com/Roblox/foreman, as its a commonly used toolchain manager in the Luau community, and foreman uses GitHub releases for its downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to build/test/release workflows extension Concerns the VSCode extension
Projects
None yet
Development

No branches or pull requests

1 participant